diff options
| -rwxr-xr-x | README | 2 | ||||
| -rw-r--r-- | pci/pci_skel.c | 5 | ||||
| -rw-r--r-- | usb/usb-skeleton.c | 5 |
3 files changed, 7 insertions, 5 deletions
@@ -25,4 +25,4 @@ $ export KERNELDIR=/path/to/linux $ cd ldd3 $ make -Bugs, comments or patches: martinez.javier@gmail.com
\ No newline at end of file +Bugs, comments or patches: martinez.javier@gmail.com diff --git a/pci/pci_skel.c b/pci/pci_skel.c index 700b9cb..3ac021d 100644 --- a/pci/pci_skel.c +++ b/pci/pci_skel.c @@ -23,7 +23,10 @@ static int probe(struct pci_dev *dev, const struct pci_device_id *id) /* Do probing type stuff here. * Like calling request_region(); */ - pci_enable_device(dev); + if(pci_enable_device(dev)) { + dev_err(&dev->dev, "can't enable PCI device\n"); + return -ENODEV; + } if (skel_get_revision(dev) == 0x42) return -ENODEV; diff --git a/usb/usb-skeleton.c b/usb/usb-skeleton.c index 82f3adf..08eb9db 100644 --- a/usb/usb-skeleton.c +++ b/usb/usb-skeleton.c @@ -235,12 +235,11 @@ static int skel_probe(struct usb_interface *interface, const struct usb_device_i int retval = -ENOMEM; /* allocate memory for our device state and initialize it */ - dev = kmalloc(sizeof(struct usb_skel), GFP_KERNEL); - if (dev == NULL) { + dev = kzalloc(sizeof(struct usb_skel), GFP_KERNEL); + if (!dev) { pr_err("Out of memory"); goto error; } - memset(dev, 0x00, sizeof (*dev)); kref_init(&dev->kref); dev->udev = usb_get_dev(interface_to_usbdev(interface)); |